linux-kernel - RE: [PATCH v2] drm/bridge: it6505: Power on downstream device in .atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7c9c0b2a35e45f89cb7d6d7646396f2@ite.com.tw>
Date:   Thu, 14 Jul 2022 10:41:51 +0000
From:   <allen.chen@....com.tw>
To:     <treapking@...omium.org>, <andrzej.hajda@...el.com>,
        <narmstrong@...libre.com>, <robert.foss@...aro.org>,
        <Laurent.pinchart@...asonboard.com>, <jonas@...boo.se>,
        <jernej.skrabec@...il.com>, <airlied@...ux.ie>, <daniel@...ll.ch>
CC:     <hsinyi@...omium.org>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <Kenneth.Hung@....com.tw>,
        <Jau-Chih.Tseng@....com.tw>, <Hermes.Wu@....com.tw>
Subject: RE: [PATCH v2] drm/bridge: it6505: Power on downstream device in
 .atomic_enable

Reviewed-by: Allen Chen <allen.chen@....com.tw>

-----Original Message-----
From: Pin-Yen Lin <treapking@...omium.org> 
Sent: Thursday, July 14, 2022 5:39 PM
To: Andrzej Hajda <andrzej.hajda@...el.com>; Neil Armstrong <narmstrong@...libre.com>; Robert Foss <robert.foss@...aro.org>; Laurent Pinchart <Laurent.pinchart@...asonboard.com>; Jonas Karlman <jonas@...boo.se>; Jernej Skrabec <jernej.skrabec@...il.com>; David Airlie <airlied@...ux.ie>; Daniel Vetter <daniel@...ll.ch>
Cc: Hsin-Yi Wang <hsinyi@...omium.org>; Allen Chen (陳柏宇) <allen.chen@....com.tw>; Pin-Yen Lin <treapking@...omium.org>; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org
Subject: [PATCH v2] drm/bridge: it6505: Power on downstream device in .atomic_enable

Send DPCD DP_SET_POWER_D0 command to the monitor in .atomic_enable callback. Without this command, some monitors won't show up again after changing the resolution.

Fixes: 46ca7da7f1e8 ("drm/bridge: it6505: Send DPCD SET_POWER to downstream")

Signed-off-by: Pin-Yen Lin <treapking@...omium.org>
---

Changes in v2:
- Update the typo in the summary (power on --> power off)
- Re-write the commit message to make it clearer.

 drivers/gpu/drm/bridge/ite-it6505.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 4b673c4792d7..e5626035f311 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -2945,6 +2945,9 @@ static void it6505_bridge_atomic_enable(struct drm_bridge *bridge,
 	if (ret)
 		dev_err(dev, "Failed to setup AVI infoframe: %d", ret);
 
+	it6505_drm_dp_link_set_power(&it6505->aux, &it6505->link,
+				     DP_SET_POWER_D0);
+
 	it6505_update_video_parameter(it6505, mode);
 
 	ret = it6505_send_video_infoframe(it6505, &frame);
--
2.37.0.144.g8ac04bfd2-goog