linux-kernel - [morimoto:sound2-2022-07-11-v2 13/16] sound/soc/soc-core.c:965:5: warning: no previous prototype for function '__snd_soc_add_pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 14 Jul 2022 19:02:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: [morimoto:sound2-2022-07-11-v2 13/16] sound/soc/soc-core.c:965:5:
 warning: no previous prototype for function '__snd_soc_add_pcm_runtime'

tree:   https://github.com/morimoto/linux sound2-2022-07-11-v2
head:   7a876d470ffed6b8de10e0ae0c1a607f3666dec4
commit: 034c2fe28518544636a5a81799009ba7892a5131 [13/16] ASoC: force to use DPCM on normal connection
config: i386-randconfig-a006
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5e61b9c556267086ef9b743a0b57df302eef831b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/morimoto/linux/commit/034c2fe28518544636a5a81799009ba7892a5131
        git remote add morimoto https://github.com/morimoto/linux
        git fetch --no-tags morimoto sound2-2022-07-11-v2
        git checkout 034c2fe28518544636a5a81799009ba7892a5131
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash sound/soc/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> sound/soc/soc-core.c:965:5: warning: no previous prototype for function '__snd_soc_add_pcm_runtime' [-Wmissing-prototypes]
   int __snd_soc_add_pcm_runtime(struct snd_soc_card *card,
       ^
   sound/soc/soc-core.c:965:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __snd_soc_add_pcm_runtime(struct snd_soc_card *card,
   ^
   static 
   1 warning generated.
--
>> sound/soc/soc-core.c:967: warning: expecting prototype for snd_soc_add_pcm_runtime(). Prototype was for __snd_soc_add_pcm_runtime() instead


vim +/__snd_soc_add_pcm_runtime +965 sound/soc/soc-core.c

   953	
   954	/**
   955	 * snd_soc_add_pcm_runtime - Add a pcm_runtime dynamically via dai_link
   956	 * @card: The ASoC card to which the pcm_runtime is added
   957	 * @dai_link: The DAI link to find pcm_runtime
   958	 *
   959	 * This function adds a pcm_runtime ASoC card by using dai_link.
   960	 *
   961	 * Note: Topology can use this API to add pcm_runtime when probing the
   962	 * topology component. And machine drivers can still define static
   963	 * DAI links in dai_link array.
   964	 */
 > 965	int __snd_soc_add_pcm_runtime(struct snd_soc_card *card,
   966				    struct snd_soc_dai_link *dai_link)
 > 967	{
   968		struct snd_soc_pcm_runtime *rtd;
   969		struct snd_soc_dai_link_component *codec, *platform, *cpu;
   970		struct snd_soc_component *component;
   971		int i, ret;
   972	
   973		lockdep_assert_held(&client_mutex);
   974	
   975		/*
   976		 * Notify the machine driver for extra initialization
   977		 */
   978		ret = snd_soc_card_add_dai_link(card, dai_link);
   979		if (ret < 0)
   980			return ret;
   981	
   982		if (dai_link->ignore)
   983			return 0;
   984	
   985		dev_dbg(card->dev, "ASoC: binding %s\n", dai_link->name);
   986	
   987		ret = soc_dai_link_sanity_check(card, dai_link);
   988		if (ret < 0)
   989			return ret;
   990	
   991		rtd = soc_new_pcm_runtime(card, dai_link);
   992		if (!rtd)
   993			return -ENOMEM;
   994	
   995		for_each_link_cpus(dai_link, i, cpu) {
   996			asoc_rtd_to_cpu(rtd, i) = snd_soc_find_dai(cpu);
   997			if (!asoc_rtd_to_cpu(rtd, i)) {
   998				dev_info(card->dev, "ASoC: CPU DAI %s not registered\n",
   999					 cpu->dai_name);
  1000				goto _err_defer;
  1001			}
  1002			snd_soc_rtd_add_component(rtd, asoc_rtd_to_cpu(rtd, i)->component);
  1003		}
  1004	
  1005		/* Find CODEC from registered CODECs */
  1006		for_each_link_codecs(dai_link, i, codec) {
  1007			asoc_rtd_to_codec(rtd, i) = snd_soc_find_dai(codec);
  1008			if (!asoc_rtd_to_codec(rtd, i)) {
  1009				dev_info(card->dev, "ASoC: CODEC DAI %s not registered\n",
  1010					 codec->dai_name);
  1011				goto _err_defer;
  1012			}
  1013	
  1014			snd_soc_rtd_add_component(rtd, asoc_rtd_to_codec(rtd, i)->component);
  1015		}
  1016	
  1017		/* Find PLATFORM from registered PLATFORMs */
  1018		for_each_link_platforms(dai_link, i, platform) {
  1019			for_each_component(component) {
  1020				if (!snd_soc_is_matching_component(platform, component))
  1021					continue;
  1022	
  1023				snd_soc_rtd_add_component(rtd, component);
  1024			}
  1025		}
  1026	
  1027		return 0;
  1028	
  1029	_err_defer:
  1030		snd_soc_remove_pcm_runtime(card, rtd);
  1031		return -EPROBE_DEFER;
  1032	}
  1033	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (151358 bytes)