linux-kernel - Re: [PATCH RESEND -next] lsm_audit: Clean up redundant NULL pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4b4833e-7c28-9b7f-76d9-a1c5335368dd@huawei.com>
Date:   Thu, 14 Jul 2022 10:48:56 +0800
From:   xiujianfeng <xiujianfeng@...wei.com>
To:     Paul Moore <paul@...l-moore.com>
CC:     <jmorris@...ei.org>, <serge@...lyn.com>,
        <linux-security-module@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND -next] lsm_audit: Clean up redundant NULL pointer
 check


在 2022/7/14 10:33, Paul Moore 写道:
> On Wed, Jul 13, 2022 at 9:27 PM Xiu Jianfeng <xiujianfeng@...wei.com> wrote:
>> The implements of {ip,tcp,udp,dccp,sctp,ipv6}_hdr(skb) guarantee that
>> they will never return NULL, and elsewhere users don't do the check
>> as well, so remove the check here.
>>
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>
>> ---
>>   security/lsm_audit.c | 14 +-------------
>>   1 file changed, 1 insertion(+), 13 deletions(-)
> Hi Xiu Jianfeng,
>
> We just changed LSM maintainers earlier this week, and while I haven't
> forgotten about your patch (I reviewed it previously), it is too late
> in this current release cycle (-rc6) to merge non-critical fixes.
> This would go into the LSM tree after the upcoming merge window.
>
> Thank you for your patience and understanding.
Hi, paul, I get it, thanks very much :)
>