linux-kernel - Re: [PATCH v2] usb: serial: qcserial: add EM9191 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F3F460AC-05D0-4DF9-9C18-B95881B62F8F@gmail.com>
Date:   Fri, 15 Jul 2022 23:28:33 +0200
From:   Frans Klaver <fransklaver@...il.com>
To:     Reinhard Speyerer <rspmn@...or.de>
CC:     Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Frans Klaver <frans.klaver@...link.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2] usb: serial: qcserial: add EM9191 support



On July 15, 2022 11:00:45 PM GMT+02:00, Reinhard Speyerer <rspmn@...or.de> wrote:

>the qcserial driver used in the usb-devices output above does not seem
>to be built from the mainline qcserial.c with your patch applied as USB
>interface 4 is ignored by the QCSERIAL_SWI layout.

Right, I will need to look into that then. I won't be able to access the devices for a couple of weeks, though. It might also just have been me no paying attention while testing. I'll get back to this. 


>To avoid potential side effects in case Sierra Wireless adds a vendor class
>USB interface 2 not intended to be used with qcserial.c it might be best
>to use a new QCSERIAL_SWI2 layout similar to what has been done in
>their MBPL drivers mentioned here
>https://forum.sierrawireless.com/t/rc7620-and-linux-driver/24308/ .

I'll have a look at this too. 

Thanks, 
Frans