linux-kernel - Re: [PATCH] mtd: spi-nor: winbond: add support for W25Q512NW-IQ/IN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0273ed77-73d8-bbd4-4626-4e7f17db74d1@quicinc.com>
Date:   Fri, 15 Jul 2022 16:26:16 -0700
From:   Jae Hyun Yoo <quic_jaehyoo@...cinc.com>
To:     Michael Walle <michael@...le.cc>
CC:     <clg@...d.org>, <linux-kernel@...r.kernel.org>,
        <linux-mtd@...ts.infradead.org>, <p.yadav@...com>,
        <quic_ggregory@...cinc.com>, <quic_jiles@...cinc.com>,
        <tudor.ambarus@...rochip.com>
Subject: Re: [PATCH] mtd: spi-nor: winbond: add support for W25Q512NW-IQ/IN

Hi,

On 7/15/2022 4:20 PM, Michael Walle wrote:
> Hi,
> 
>>> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
>>> index ce5d69317d46..a2c8de250e01 100644
>>> --- a/drivers/mtd/spi-nor/core.c
>>> +++ b/drivers/mtd/spi-nor/core.c
>>> @@ -2113,6 +2113,10 @@ spi_nor_select_uniform_erase(struct 
>>> spi_nor_erase_map *map,
>>>
>>>                  tested_erase = &map->erase_type[i];
>>>
>>> +               /* Skip masked erase types. */
>>> +               if (!tested_erase->size)
>>> +                       continue;
>>
>> Yes, it also works. Do you want me to update this patch with adding this
>> fix? Or is it good to go as is so that the INFO table can be replaced
>> with SNOR_ID3 later after the fix is merged?
> 
> Please add this as a separate preceding patch to your original one
> where you add the flash. Keep the INFO(0xef6020, 0, 0, 0). Then we
> will replace it later with the SNOR_ID3().

Sure, I'll submit v3 series including the fix then.

Thanks,
Jae

> Thanks for debugging!
> -michael