linux-kernel - Re: [PATCH v8 2/2] iio: adc: ad4130: add AD4130 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08a9d34b-f44e-e1f2-ebc6-4123986b3c54@gmail.com>
Date:   Fri, 15 Jul 2022 07:53:03 +0300
From:   Cosmin Tanislav <demonsingur@...il.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-iio@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Cosmin Tanislav <cosmin.tanislav@...log.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v8 2/2] iio: adc: ad4130: add AD4130 driver



On 7/15/22 07:49, Cosmin Tanislav wrote:
> AD4130-8 is an ultra-low power, high precision, measurement solution for
> low bandwidth battery operated applications.
> 
> The fully integrated AFE (Analog Front-End) includes a multiplexer for up
> to 16 single-ended or 8 differential inputs, PGA (Programmable Gain
> Amplifier), 24-bit Sigma-Delta ADC, on-chip reference and oscillator,
> selectable filter options, smart sequencer, sensor biasing and excitation
> options, diagnostics, and a FIFO buffer.
> 
> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@...log.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> ...
> +static int ad4130_gpio_init_valid_mask(struct gpio_chip *gc,
> +				       unsigned long *valid_mask,
> +				       unsigned int ngpios)
> +{
> +	struct ad4130_state *st = gpiochip_get_data(gc);
> +	unsigned int i;
> +
> +	/*
> +	 * Output-only GPIO functionality is available on pins AIN2 through
> +	 * AIN5. If these pins are used for anything else, do not expose them.
> +	 */
> +	for (i = 0; i < ngpios; i++) {
> +		unsigned int pin = i + AD4130_AIN2_P1;
> +		bool valid = st->pins_fn[pin] == AD4130_PIN_FN_NONE;
> +
> +		__assign_bit(i, valid_mask, valid);
> +	}
> +
> +

I missed an extra blank line here. Maybe you could fix it while
picking the patchset up, Jonathan?

> +	return 0;
> +}
> +
> ...