linux-kernel - Re: [PATCH v2] Bluetooth: hci_sync: Remove redundant func definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 Jul 2022 15:47:01 +0800
From:   quic_zijuhu <quic_zijuhu@...cinc.com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>
CC:     <marcel@...tmann.org>, <johan.hedberg@...il.com>,
        <luiz.dentz@...il.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <luiz.von.dentz@...el.com>, <linux-kernel@...r.kernel.org>,
        <linux-bluetooth@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] Bluetooth: hci_sync: Remove redundant func definition

On 7/15/2022 3:34 PM, Paul Menzel wrote:
> Dear Zijun,
> 
> 
> Thank you for the patch.
> 
> Am 15.07.22 um 06:14 schrieb Zijun Hu:
>> both hci_request.c and hci_sync.c have the same definition
>> for disconnected_accept_list_entries(), so remove a redundant
>> copy.
> 
> Please use 75 characters per line for Linux commit message bodies. That way, only two instead of three lines are needed.
thanks for your suggestion, correct within v4 sent. could you code review again?
>> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
>> ---
>> v1->v2
>>     -remove the func copy within hci_request.c instead of hci_sync.c
>>   net/bluetooth/hci_request.c | 18 ------------------
>>   net/bluetooth/hci_request.h |  2 ++
>>   net/bluetooth/hci_sync.c    |  2 +-
>>   3 files changed, 3 insertions(+), 19 deletions(-)
> 
> […]
> 
> 
> Kind regards,
> 
> Paul