linux-kernel - Re: [PATCH] crypto: lib/arc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YtDLMmwffn6p/rSV@sol.localdomain>
Date:   Thu, 14 Jul 2022 19:04:34 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Christian Marangi <ansuelsmth@...il.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: lib/arc4 - expose library interface

On Thu, Jul 14, 2022 at 07:12:21AM +0200, Christian Marangi wrote:
> Permit to compile the arc4 crypto lib without any user. This is required
> by the backports project [1] that require this lib for any wireless
> driver.
> 
> [1] https://backports.wiki.kernel.org/index.php/Main_Page
> 
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
>  lib/crypto/Kconfig | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/crypto/Kconfig b/lib/crypto/Kconfig
> index 2082af43d51f..2dfc785a7817 100644
> --- a/lib/crypto/Kconfig
> +++ b/lib/crypto/Kconfig
> @@ -6,7 +6,11 @@ config CRYPTO_LIB_AES
>  	tristate
>  
>  config CRYPTO_LIB_ARC4
> -	tristate
> +	tristate "ARC4 library interface"
> +	help
> +	  Enable the ARC4 library interface. This interface is mainly
> +	  used by wireless drivers and is required by the backports
> +	  project.
>  
>  config CRYPTO_ARCH_HAVE_LIB_BLAKE2S
>  	bool

I don't think this is appropriate for upstream, as the upstream kernel doesn't
support out-of-tree code.  This is also an internal API that can change from one
kernel version to the next.

- Eric