linux-kernel - Re: [PATCH 1/3] ads7846: don't report pressure for ads7845

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41375332-6d48-2fee-6768-22b639090e3e@brickedbrain.com>
Date:   Fri, 15 Jul 2022 16:36:06 +0200
From:   Luca Ellero <luca.ellero@...ckedbrain.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     dmitry.torokhov@...il.com, daniel@...que.org,
        m.felsch@...gutronix.de, u.kleine-koenig@...gutronix.de,
        mkl@...gutronix.de, miquel.raynal@...tlin.com, imre.deak@...ia.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Luca Ellero <l.ellero@...m.it>
Subject: Re: [PATCH 1/3] ads7846: don't report pressure for ads7845

On 14/07/2022 13:32, Andy Shevchenko wrote:
> On Thu, Jul 14, 2022 at 10:43:17AM +0200, Luca Ellero wrote:
>> From: Luca Ellero <l.ellero@...m.it>
>>
>> ADS7845 doesn't support pressure.
>> This patch avoids the following error reported by libinput-list-devices:
>> "ADS7845 Touchscreen: kernel bug: device has min == max on ABS_PRESSURE"
> 
> Missed period, otherwise looks good.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
>> Signed-off-by: Luca Ellero <l.ellero@...m.it>
>> ---
>>   drivers/input/touchscreen/ads7846.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
>> index bed68a68f330..24605c40d039 100644
>> --- a/drivers/input/touchscreen/ads7846.c
>> +++ b/drivers/input/touchscreen/ads7846.c
>> @@ -1316,8 +1316,9 @@ static int ads7846_probe(struct spi_device *spi)
>>   			pdata->y_min ? : 0,
>>   			pdata->y_max ? : MAX_12BIT,
>>   			0, 0);
>> -	input_set_abs_params(input_dev, ABS_PRESSURE,
>> -			pdata->pressure_min, pdata->pressure_max, 0, 0);
>> +	if (ts->model != 7845)
>> +		input_set_abs_params(input_dev, ABS_PRESSURE,
>> +				pdata->pressure_min, pdata->pressure_max, 0, 0);
>>   
>>   	/*
>>   	 * Parse common framework properties. Must be done here to ensure the
>> -- 
>> 2.25.1
>>
> 

Hi Andy,
thank you for your comments.
I will resend v2 of the patches.
Regards
Luca

-- 
Luca Ellero

E-mail: luca.ellero@...ckedbrain.com
Internet: www.brickedbrain.com