linux-kernel - Re: [net-next: PATCH v2 1/8] net: phy: fixed_phy: switch to fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5b55fb3-3326-eb3c-99e6-3fd6b7e4c2fe@gmail.com>
Date:   Fri, 15 Jul 2022 10:20:55 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Marcin Wojtas <mw@...ihalf.com>, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, netdev@...r.kernel.org
Cc:     rafael@...nel.org, andriy.shevchenko@...ux.intel.com,
        sean.wang@...iatek.com, Landen.Chao@...iatek.com,
        linus.walleij@...aro.org, andrew@...n.ch, vivien.didelot@...il.com,
        olteanv@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk,
        hkallweit1@...il.com, gjb@...ihalf.com, jaz@...ihalf.com,
        tn@...ihalf.com, Samer.El-Haj-Mahmoud@....com,
        upstream@...ihalf.com
Subject: Re: [net-next: PATCH v2 1/8] net: phy: fixed_phy: switch to fwnode_
 API

On 7/15/22 01:50, Marcin Wojtas wrote:
> This patch allows to use fixed_phy driver and its helper
> functions without Device Tree dependency, by swtiching from
> of_ to fwnode_ API.
> 
> Signed-off-by: Marcin Wojtas <mw@...ihalf.com>
> ---
>  include/linux/phy_fixed.h   |  4 +-
>  drivers/net/mdio/of_mdio.c  |  2 +-
>  drivers/net/phy/fixed_phy.c | 39 +++++++-------------
>  3 files changed, 17 insertions(+), 28 deletions(-)
> 
> diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h
> index 52bc8e487ef7..449a927231ec 100644
> --- a/include/linux/phy_fixed.h
> +++ b/include/linux/phy_fixed.h
> @@ -19,7 +19,7 @@ extern int fixed_phy_add(unsigned int irq, int phy_id,
>  			 struct fixed_phy_status *status);
>  extern struct phy_device *fixed_phy_register(unsigned int irq,
>  					     struct fixed_phy_status *status,
> -					     struct device_node *np);
> +					     struct fwnode_handle *fwnode);

I think this ought to require a forward declaration of struct fwnode_handle and a removal of the forward declaration of device_node.

With that fixes:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian