linux-kernel - Re: [PATCH] riscv: dts: microchip: hook up the mpfs' l2cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1804ca07-253f-c4f3-1328-e2e500b9dd9d@microchip.com>
Date:   Fri, 15 Jul 2022 17:38:35 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <palmer@...osinc.com>, <conor@...nel.org>
CC:     <Daire.McNamara@...rochip.com>, <Ivan.Griffin@...rochip.com>,
        <linux-riscv@...ts.infradead.org>, <Conor.Dooley@...rochip.com>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <paul.walmsley@...ive.com>, <aou@...s.berkeley.edu>,
        <atishp@...shpatra.org>, <sudeep.holla@....com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] riscv: dts: microchip: hook up the mpfs' l2cache

On 15/07/2022 18:32, Palmer Dabbelt wrote:
> On Wed, 29 Jun 2022 13:07:33 PDT (-0700), conor@...nel.org wrote:
>> From: Conor Dooley <conor.dooley@...rochip.com>
>>
>> The initial PolarFire SoC devicetree must have been forked off from
>> the fu540 one prior to the addition of l2cache controller support being
>> added there. When the controller node was added to mpfs.dtsi, it was
>> not hooked up to the CPUs & thus sysfs reports an incorrect cache
>> configuration. Hook it up.
>>
>> Fixes: 0fa6107eca41 ("RISC-V: Initial DTS for Microchip ICICLE board")
> 
> I just noticed this as I was looking over the PR I just sent, but since you're sending PRs I'm no longer re-writing your commits and thus I won't be adding stable CCs.  If you want stuff CC'd to stable you'll have to either add it to the tags in the commit, or do so after the fact.

Or option 3, Sasha AUTOSELs it :)

Good point though, I'll make sure to tack on the CC:stable where
needed. I *think* that I have not done this isn't the worst thing
in the world since it is only two patches & only one kernel to
backport it to, but I'll make sure to do it going forward.

Thanks Palmer.