linux-kernel - Re: [PATCH] io_uring: Don't require reinitable percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f5cab9f-9c18-7114-2ca1-ad4eff13eb63@kernel.dk>
Date:   Fri, 15 Jul 2022 12:22:05 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Michal Koutný <mkoutny@...e.com>
Cc:     asml.silence@...il.com, fam.zheng@...edance.com,
        io-uring@...r.kernel.org, linux-kernel@...r.kernel.org,
        roman.gushchin@...ux.dev, usama.arif@...edance.com
Subject: Re: [PATCH] io_uring: Don't require reinitable percpu_ref

On 7/15/22 11:45 AM, Michal Koutn? wrote:
> The commit 8bb649ee1da3 ("io_uring: remove ring quiesce for
> io_uring_register") removed the worklow relying on reinit/resurrection
> of the percpu_ref, hence, initialization with that requested is a relic.
> 
> This is based on code review, this causes no real bug (and theoretically
> can't). Technically it's a revert of commit 214828962dea ("io_uring:
> initialize percpu refcounters using PERCU_REF_ALLOW_REINIT") but since
> the flag omission is now justified, I'm not making this a revert.

Thanks, applied manually for 5.20 (new file location).

-- 
Jens Axboe