linux-kernel - Re: [PATCH 0/2] ucount: Fix and improve atomic_long_inc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ilnyz10o.fsf@email.froward.int.ebiederm.org>
Date:   Fri, 15 Jul 2022 13:25:27 -0500
From:   "Eric W. Biederman" <ebiederm@...ssion.com>
To:     Uros Bizjak <ubizjak@...il.com>
Cc:     linux-kernel@...r.kernel.org, Alexey Gladkov <legion@...nel.org>
Subject: Re: [PATCH 0/2] ucount: Fix and improve atomic_long_inc_below

Uros Bizjak <ubizjak@...il.com> writes:

> The series fixes wrong argument type and improves atomic_long_inc_below
> by using atomic_long_try_cmpxchg instead of atomic_long_cmpxchg.
>
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> Cc: "Eric W. Biederman" <ebiederm@...ssion.com>

The bug fix at least looks correct.  I haven't reviewed the
atomic_long_try_cmpxchg yet.

Thanks,
Eric

>
> Uros Bizjak (2):
>   ucount: Fix atomic_long_inc_below argument type
>   ucount: Use atomic_long_try_cmpxchg in atomic_long_inc_below
>
>  kernel/ucount.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)