linux-kernel - Re: [PATCH] nvme: Use command_id instead of req->tag in trace_nvme_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e2c6bc4-8aef-3334-fbbf-d67e7de617fe@kernel.dk>
Date:   Fri, 15 Jul 2022 13:51:24 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Bean Huo <beanhuo@...pp.de>, kbusch@...nel.org, axboe@...com,
        hch@....de, sagi@...mberg.me, linux-nvme@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, beanhuo@...ron.com
Subject: Re: [PATCH] nvme: Use command_id instead of req->tag in
 trace_nvme_complete_rq()

On 7/15/22 1:48 PM, Bean Huo wrote:
> From: Bean Huo <beanhuo@...ron.com>
> 
> use command_id instead of req->tag in trace_nvme_complete_rq(),
> because of commit e7006de6c238 ("nvme: code command_id with a genctr
> for use authentication after release"), cmd->common.command_id is set to
> ((genctl & 0xf)< 12 | req->tag), no longer req->tag, which makes cid in
> trace_nvme_complete_rq and trace_nvme_setup_cmd are not the same.

Needs a fixes tag.

-- 
Jens Axboe