linux-kernel - Re: [PATCH] scsi: ufs: ufs-pci: Correct check for RESET DSM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8919f85e-41d3-1fff-962a-9972064307d3@acm.org>
Date:   Fri, 15 Jul 2022 13:08:35 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Daniil Lunev <dlunev@...omium.org>,
        Adrian Hunter <adrian.hunter@...el.com>
Cc:     Avri Altman <avri.altman@....com>, Bean Huo <beanhuo@...ron.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] scsi: ufs: ufs-pci: Correct check for RESET DSM

On 7/15/22 05:48, Daniil Lunev wrote:
> +#define __INTEL_DSM_SUPPORTED(host, fn) \
> +	((fn) < 32 && (fn) >= 0 && ((host)->dsm_fns & (1 << (fn))))

Could this macro have been implemented as a function?

Should '1 << (fn)' perhaps be changed into '1u << (fn)'?

Thanks,

Bart.