linux-kernel - Re: [PATCH v3 2/2] mtd: spi-nor: winbond: add support for W25Q512NW-IQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52fb683e27b3208d07d9f9d1ab44148d@walle.cc>
Date:   Sat, 16 Jul 2022 11:11:35 +0200
From:   Michael Walle <michael@...le.cc>
To:     Jae Hyun Yoo <quic_jaehyoo@...cinc.com>
Cc:     Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Pratyush Yadav <p.yadav@...com>,
        Jamie Iles <quic_jiles@...cinc.com>,
        Graeme Gregory <quic_ggregory@...cinc.com>,
        Cédric Le Goater <clg@...d.org>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] mtd: spi-nor: winbond: add support for
 W25Q512NW-IQ

Hi,

Am 2022-07-16 02:06, schrieb Jae Hyun Yoo:
> Add support for Winbond W25Q512NW-IQ/IN
> 
> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@...cinc.com>
> Link: 
> https://www.winbond.com/resource-files/W25Q512NW%20RevB%2007192021.pdf
> Reviewed-by: Cédric Le Goater <clg@...d.org>

Thanks again for finding the real issue here!

Reviewed-by: Michael Walle <michael@...le.cc>

But also see below.

> $ hexdump
> /sys/bus/platform/devices/1e620000.spi/spi_master/spi0/spi0.1/spi-nor/sfdp
> 0000000 4653 5044 0106 ff01 0600 1001 0080 ff00
> 0000010 0084 0201 00d0 ff00 ffff ffff ffff ffff
> 0000020 6f00 7074 7420 7365 ff74 ffff ffff ffff

Did you noticed your SFDP data changed compared to:
https://lore.kernel.org/linux-mtd/20220710145721.1207157-1-quic_jaehyoo@quicinc.com/

Which makes me wonder if you ever had an offset 0
with the OTP_INFO(). For Winbond the first OTP
region is actually the SFDP.. So you might
accidentally modified it.

-michael