linux-kernel - Re: [PATCH v3 1/1] gpio: mpfs: add polarfire soc gpio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pmi549rp.wl-maz@kernel.org>
Date:   Sat, 16 Jul 2022 11:44:26 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     <lewis.hanly@...rochip.com>
Cc:     <linux-gpio@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
        <linus.walleij@...aro.org>, <brgl@...ev.pl>,
        <linux-kernel@...r.kernel.org>, <palmer@...belt.com>,
        <conor.dooley@...rochip.com>, <daire.mcnamara@...rochip.com>
Subject: Re: [PATCH v3 1/1] gpio: mpfs: add polarfire soc gpio support

On Sat, 16 Jul 2022 08:11:13 +0100,
<lewis.hanly@...rochip.com> wrote:
> 
> From: Lewis Hanly <lewis.hanly@...rochip.com>
> 
> Add a driver to support the Polarfire SoC gpio controller.
> 
> Signed-off-by: Lewis Hanly <lewis.hanly@...rochip.com>
> ---
>  drivers/gpio/Kconfig     |   9 +
>  drivers/gpio/Makefile    |   1 +
>  drivers/gpio/gpio-mpfs.c | 361 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 371 insertions(+)
>  create mode 100644 drivers/gpio/gpio-mpfs.c

A couple of other nits:

> +static const struct of_device_id mpfs_of_ids[] = {
> +	{ .compatible = "microchip,mpfs-gpio", },

Where is the DT binding for this?

> +	{ /* end of list */ }
> +};
> +
> +static struct platform_driver mpfs_gpio_driver = {
> +	.probe = mpfs_gpio_probe,
> +	.driver = {
> +		.name = "microchip,mpfs-gpio",
> +		.of_match_table = mpfs_of_ids,
> +	},
> +	.remove = mpfs_gpio_remove,

No, please. You cannot enforce that there are no interrupts being used
(and nothing checks for this), and you're pretty much guaranteed that
the system will catch fire on the first interrupt being delivered.
Moreover, your "remove" callback only turns the clock off, which is
yet another nail on that coffin.

	M.

-- 
Without deviation from the norm, progress is not possible.