linux-kernel - Re: [PATCH] power: supply: Fix typo in power_supply_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220716224752.zvee6zml42ezomjj@mercury.elektranox.org>
Date:   Sun, 17 Jul 2022 00:47:52 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Schspa Shi <schspa@...il.com>
Cc:     myungjoo.ham@...sung.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: Fix typo in power_supply_check_supplies

Hi,

On Tue, Jul 05, 2022 at 11:32:44AM +0800, Schspa Shi wrote:
> It seems to be a typo, there is no actual BUG, but it's better to
> fix it to avoid any possible BUG after we change the type of
> supplied_from.
> 
> Signed-off-by: Schspa Shi <schspa@...il.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/power_supply_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c
> index fad5890c899e..02228d68c599 100644
> --- a/drivers/power/supply/power_supply_core.c
> +++ b/drivers/power/supply/power_supply_core.c
> @@ -263,13 +263,13 @@ static int power_supply_check_supplies(struct power_supply *psy)
>  		return 0;
>  
>  	/* All supplies found, allocate char ** array for filling */
> -	psy->supplied_from = devm_kzalloc(&psy->dev, sizeof(psy->supplied_from),
> +	psy->supplied_from = devm_kzalloc(&psy->dev, sizeof(*psy->supplied_from),
>  					  GFP_KERNEL);
>  	if (!psy->supplied_from)
>  		return -ENOMEM;
>  
>  	*psy->supplied_from = devm_kcalloc(&psy->dev,
> -					   cnt - 1, sizeof(char *),
> +					   cnt - 1, sizeof(**psy->supplied_from),
>  					   GFP_KERNEL);
>  	if (!*psy->supplied_from)
>  		return -ENOMEM;
> -- 
> 2.29.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)