linux-kernel - Re: [PATCH] power: supply: ab8500_fg: drop unexpected word 'is' in the comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 17 Jul 2022 01:04:30 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Jiang Jian <jiangjian@...rlc.com>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] power: supply: ab8500_fg: drop unexpected word 'is' in
 the comments

Hi,

On Thu, Jun 23, 2022 at 01:14:10AM +0800, Jiang Jian wrote:
> there is an unexpected word 'is' in the comments that need to be dropped
> 
> file - drivers/power/supply/ab8500_fg.c
> line - 415
> 
> * The capacity filter is is reset to zero.
> 
> changed to:
> 
> * The capacity filter is reset to zero.
> 
> Signed-off-by: Jiang Jian <jiangjian@...rlc.com>
> ---

Thanks, queued with shortened commit message. No need to describe
what exactly has changed, that's obvious from the patch diff...
Instead commit messages should say _why_ something changed, so in
this case something along the lines 'fix word duplication' is
enough.

-- Sebastian

>  drivers/power/supply/ab8500_fg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/ab8500_fg.c b/drivers/power/supply/ab8500_fg.c
> index 4339fa9ff009..12eafeca83e1 100644
> --- a/drivers/power/supply/ab8500_fg.c
> +++ b/drivers/power/supply/ab8500_fg.c
> @@ -412,7 +412,7 @@ static int ab8500_fg_add_cap_sample(struct ab8500_fg *di, int sample)
>   * ab8500_fg_clear_cap_samples() - Clear average filter
>   * @di:		pointer to the ab8500_fg structure
>   *
> - * The capacity filter is is reset to zero.
> + * The capacity filter is reset to zero.
>   */
>  static void ab8500_fg_clear_cap_samples(struct ab8500_fg *di)
>  {
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)