linux-kernel - fs/io_uring.c:9355:9: warning: variable 'ret' is uninitialized when used here

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 17 Jul 2022 07:41:24 +0800
From:   kernel test robot <lkp@...el.com>
To:     Usama Arif <usama.arif@...edance.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, 0day robot <lkp@...el.com>
Subject: fs/io_uring.c:9355:9: warning: variable 'ret' is uninitialized when
 used here

tree:   https://github.com/intel-lab-lkp/linux/commits/UPDATE-20220716-232000/Usama-Arif/io_uring-remove-ring-quiesce-in-io_uring_register/20220204-225343
head:   a5e1e37e8b4c9ca3f59d11e31910a7f093649d31
commit: 5c6ec2f45e82c1351622414a938ca16473523b5b io_uring: avoid ring quiesce while registering/unregistering eventfd
date:   8 hours ago
config: hexagon-randconfig-r031-20220717 (https://download.01.org/0day-ci/archive/20220717/202207170736.NYpEy72b-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 07022e6cf9b5b3baa642be53d0b3c3f1c403dbfd)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/5c6ec2f45e82c1351622414a938ca16473523b5b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review UPDATE-20220716-232000/Usama-Arif/io_uring-remove-ring-quiesce-in-io_uring_register/20220204-225343
        git checkout 5c6ec2f45e82c1351622414a938ca16473523b5b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> fs/io_uring.c:9355:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
           return ret;
                  ^~~
   fs/io_uring.c:9334:13: note: initialize the variable 'ret' to silence this warning
           int fd, ret;
                      ^
                       = 0
   fs/io_uring.c:1200:20: warning: unused function 'req_ref_put' [-Wunused-function]
   static inline void req_ref_put(struct io_kiocb *req)
                      ^
   2 warnings generated.


vim +/ret +9355 fs/io_uring.c

  9329	
  9330	static int io_eventfd_register(struct io_ring_ctx *ctx, void __user *arg)
  9331	{
  9332		struct io_ev_fd *ev_fd;
  9333		__s32 __user *fds = arg;
  9334		int fd, ret;
  9335	
  9336		ev_fd = rcu_dereference_protected(ctx->io_ev_fd, lockdep_is_held(&ctx->uring_lock));
  9337		if (ev_fd)
  9338			return -EBUSY;
  9339	
  9340		if (copy_from_user(&fd, fds, sizeof(*fds)))
  9341			return -EFAULT;
  9342	
  9343		ev_fd = kmalloc(sizeof(*ev_fd), GFP_KERNEL);
  9344		if (!ev_fd)
  9345			return -ENOMEM;
  9346	
  9347		ev_fd->cq_ev_fd = eventfd_ctx_fdget(fd);
  9348		if (IS_ERR(ev_fd->cq_ev_fd)) {
  9349			ret = PTR_ERR(ev_fd->cq_ev_fd);
  9350			kfree(ev_fd);
  9351			return ret;
  9352		}
  9353	
  9354		rcu_assign_pointer(ctx->io_ev_fd, ev_fd);
> 9355		return ret;
  9356	}
  9357	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp