linux-kernel - Re: [PATCH v1 1/1] media: atomisp_gmin_platform: Switch to use acpi_evaluate_dsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 17 Jul 2022 11:42:03 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v1 1/1] media: atomisp_gmin_platform: Switch to use
 acpi_evaluate_dsm_typed()

Hi Andy,

On Fri, Jul 15, 2022 at 07:06:41PM +0300, Andy Shevchenko wrote:
> The acpi_evaluate_dsm_typed() provides a way to check the type of the
> object evaluated by _DSM call. Use it instead of open coded variant.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> index bf527b366ab3..d4cfda07f7fb 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> @@ -1207,16 +1207,13 @@ static int gmin_get_config_dsm_var(struct device *dev,
>  	if (!strcmp(var, "CamClk"))
>  		return -EINVAL;
>  
> -	obj = acpi_evaluate_dsm(handle, &atomisp_dsm_guid, 0, 0, NULL);
> +	/* Return on unexpected object type */
> +	obj = acpi_evaluate_dsm_typed(handle, &atomisp_dsm_guid, 0, 0, NULL, ACPI_TYPE_PACKAGE);

Can you please run:

	$ ./scripts/checkpatch.pl --strict --max-line-length=80

I.e. the preferred line length is 80 or less, unless there are other
reasons to keep it longer.

>  	if (!obj) {
>  		dev_info_once(dev, "Didn't find ACPI _DSM table.\n");
>  		return -EINVAL;
>  	}
>  
> -	/* Return on unexpected object type */
> -	if (obj->type != ACPI_TYPE_PACKAGE)
> -		return -EINVAL;
> -
>  #if 0 /* Just for debugging purposes */
>  	for (i = 0; i < obj->package.count; i++) {
>  		union acpi_object *cur = &obj->package.elements[i];

-- 
Kind regards,

Sakari Ailus