lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <62d3d512.1c69fb81.6e086.d251@mx.google.com>
Date:   Sun, 17 Jul 2022 11:23:28 +0200
From:   Christian Marangi <ansuelsmth@...il.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Ohad Ben-Cohen <ohad@...ery.com>,
        Baolin Wang <baolin.wang7@...il.com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v2 2/3] ARM: dts: qcom: add missing hwlock for ipq8064
 dtsi

On Sat, Jul 16, 2022 at 10:04:39PM -0500, Bjorn Andersson wrote:
> On Thu 07 Jul 05:20 CDT 2022, Christian Marangi wrote:
> 
> > Add missing hwlock for ipq8064 dtsi provided by qcom,sfpb-mutex.
> > 
> > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > ---
> >  arch/arm/boot/dts/qcom-ipq8064.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > index 4b475d98343c..cd1b43e2cab4 100644
> > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > @@ -1224,4 +1224,11 @@ sdcc3: mmc@...80000 {
> >  			};
> >  		};
> >  	};
> > +
> > +	sfpb_mutex: hwlock@...0600 {
> 
> This is an mmio device, so it should live under /soc, so I moved it
> there while applying the patch.
> 
> 
> But it would be nice if this file followed others and kept all nodes
> sorted by address (or name if they don't have an address). Also if
> addresses were padded to 8 digits, to make sorting easier.
> 
> I would much appreciate if you could find the time to prepare such a
> patch.

That will take tons of changes, but yes will make a patch to reorder all
the nodes.

> 
> > +		compatible = "qcom,sfpb-mutex";
> > +		reg = <0x01200600 0x100>;
> > +
> > +		#hwlock-cells = <1>;
> > +	};
> >  };
> > -- 
> > 2.36.1
> > 

-- 
	Ansuel

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ