linux-kernel - Re: [PATCH] leds: clevo-mail: fix Kconfig "its" grammar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220717102221.GB14285@duo.ucw.cz>
Date:   Sun, 17 Jul 2022 12:22:21 +0200
From:   Pavel Machek <pavel@....cz>
To:     Randy Dunlap <rdunlap@...radead.org>, nm127@...email.hu
Cc:     linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH] leds: clevo-mail: fix Kconfig "its" grammar

On Thu 2022-07-14 18:59:48, Randy Dunlap wrote:
> Use the possessive "its" instead of the contraction "it's"
> where appropriate.

Thank you, applied.

Hu. Hmm. Wow.

What is that? Kconfig describes very non-standard kernel interface,
and has several other typos in the it. I can fix the typos; but is
there someone still using this who would be willing to fix it?

Best regards,
								Pavel
> @@ -456,7 +456,7 @@ config LEDS_CLEVO_MAIL
>  
>  	  The driver supports two kinds of interface: using ledtrig-timer
>  	  or through /sys/class/leds/clevo::mail/brightness. As this LED
> -	  cannot change it's brightness it blinks instead. The brightness
> +	  cannot change its brightness it blinks instead. The brightness
>  	  value 0 means off, 1..127 means blink at 0.5Hz and 128..255 means
>  	  blink at 1Hz.
>  

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index acd4f754c919..eaba0a8347fa 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -447,12 +447,12 @@ config LEDS_LP8860
 
 config LEDS_CLEVO_MAIL
 	tristate "Mail LED on Clevo notebook"
-	depends on LEDS_CLASS
+	depends on LEDS_CLASS && BROKEN
 	depends on X86 && SERIO_I8042 && DMI
 	help
 	  This driver makes the mail LED accessible from userspace
-	  programs through the leds subsystem. This LED have three
-	  known mode: off, blink at 0.5Hz and blink at 1Hz.
+	  programs through the LEDs subsystem. This LED has three
+	  known modes: off, blink at 0.5Hz and blink at 1Hz.
 
 	  The driver supports two kinds of interface: using ledtrig-timer
 	  or through /sys/class/leds/clevo::mail/brightness. As this LED

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)