linux-kernel - Re: [PATCH] KVM: arm64: Fix hypervisor address symbolization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zgh8yq7q.wl-maz@kernel.org>
Date:   Sun, 17 Jul 2022 11:43:21 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Kalesh Singh <kaleshsingh@...gle.com>
Cc:     mark.rutland@....com, broonie@...nel.org,
        madvenka@...ux.microsoft.com, tabba@...gle.com, will@...nel.org,
        qperret@...gle.com, android-mm@...gle.com, kernel-team@...roid.com,
        James Morse <james.morse@....com>,
        Alexandru Elisei <alexandru.elisei@....com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: arm64: Fix hypervisor address symbolization

On Sat, 16 Jul 2022 00:58:24 +0100,
Kalesh Singh <kaleshsingh@...gle.com> wrote:
> 
> With CONFIG_RANDOMIZE_BASE=y vmlinux addresses will resolve correctly

I guess you mean *incorrectly* here, right?

> from kallsyms. Fix this by adding the KASLR offset before printing the
> symbols.
> 
> Based on arm64 for-next/stacktrace.

In general, place these remarks after the '---' line, as they don't
really make sense in the commit itself (which is likely to be merged
on a different base anyway).

> 
> Fixes: 6ccf9cb557bd ("KVM: arm64: Symbolize the nVHE HYP addresses")
> Reported-by: Fuad Tabba <tabba@...gle.com>
> Signed-off-by: Kalesh Singh <kaleshsingh@...gle.com>
> ---
>  arch/arm64/kvm/handle_exit.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/kvm/handle_exit.c b/arch/arm64/kvm/handle_exit.c
> index f66c0142b335..e43926ef2bc2 100644
> --- a/arch/arm64/kvm/handle_exit.c
> +++ b/arch/arm64/kvm/handle_exit.c
> @@ -347,10 +347,10 @@ void __noreturn __cold nvhe_hyp_panic_handler(u64 esr, u64 spsr,
>  			kvm_err("nVHE hyp BUG at: %s:%u!\n", file, line);
>  		else
>  			kvm_err("nVHE hyp BUG at: [<%016llx>] %pB!\n", panic_addr,
> -					(void *)panic_addr);
> +					(void *)(panic_addr + kaslr_offset()));
>  	} else {
>  		kvm_err("nVHE hyp panic at: [<%016llx>] %pB!\n", panic_addr,
> -				(void *)panic_addr);
> +				(void *)(panic_addr + kaslr_offset()));
>  	}
>  
>  	/*
> 

I'll fix the above as I apply the patch, no need to respin.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.