linux-kernel - Re: [PATCH v11 00/69] Introducing the Maple Tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220717130604.twluuseaopnkifct@revolver>
Date:   Sun, 17 Jul 2022 13:06:07 +0000
From:   Liam Howlett <liam.howlett@...cle.com>
To:     Yu Zhao <yuzhao@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hugh Dickins <hughd@...gle.com>
Subject: Re: [PATCH v11 00/69] Introducing the Maple Tree

* Liam R. Howlett <Liam.Howlett@...cle.com> [220717 08:42]:
> * Yu Zhao <yuzhao@...gle.com> [220717 01:58]:
> > On Sat, Jul 16, 2022 at 10:20 PM Andrew Morton
> > <akpm@...ux-foundation.org> wrote:
> > >
> > > On Sun, 17 Jul 2022 02:46:32 +0000 Liam Howlett <liam.howlett@...cle.com> wrote:
> > ...
> > >         gap = mas.index;
> > >         gap += (info->align_offset - gap) & info->align_mask;
> > > -       VM_BUG_ON(gap + info->length > info->high_limit);
> > > -       VM_BUG_ON(gap + info->length > mas.last);
> 
> What arch did you hit these on?  David asked for me to restore some of
> the BUG_ONs in these functions and I guess I got it wrong.

I think these should be removed until I better test them.

> 
> > 
> > These VM_BUG_ONs are new, and I hit the second one quickly:
> > 
> >   kernel BUG at mm/mmap.c:1631!
> >   RIP: 0010:vm_unmapped_area+0xdb/0x1c0
> >   Call Trace:
> >    <TASK>
> >    arch_get_unmapped_area+0x1ee/0x220
> >    arch_get_unmapped_area_topdown+0x25a/0x290
> >    get_unmapped_area+0x92/0x100
> >    do_mmap+0x13f/0x560
> >    vm_mmap_pgoff+0xcd/0x170