linux-kernel - Re: [PATCH v3 3/9] iio: adc: mcp3911: use correct formula for AD conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YtQVdNdMVDyOSEW8@gmail.com>
Date:   Sun, 17 Jul 2022 15:58:12 +0200
From:   Marcus Folkesson <marcus.folkesson@...il.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Kent Gustavsson <kent@...oris.se>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/9] iio: adc: mcp3911: use correct formula for AD
 conversion

Hi,

On Sat, Jul 16, 2022 at 06:18:37PM +0100, Jonathan Cameron wrote:
> On Mon,  4 Jul 2022 19:21:10 +0200
> Marcus Folkesson <marcus.folkesson@...il.com> wrote:
> 
> > The ADC conversion is actually not rail-to-rail but with a factor 1.5.
> > Make use of this factor when calculating actual voltage.
> > 
> > Fixes: 3a89b289df5d ("iio: adc: add support for mcp3911")
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
> > Acked-by: Jonathan Cameron <jic23@...nel.org>
> ?  I doubt I gave a tag (mostly because I don't give tags to patches
> I'll pick up and give a SoB on.
> 
> Note that tags have to be given explicitly in full form before you can
> add them to a patch.  If in doubt (people often given handwavey responses)
> then ask people to give an explicit tag.

Sorry for that. I will remove the tag.
I interpreted your "Otherwise looks good to me." as an acked-by.

I will only go for explicit tags forward. 

Thanks,
Marcus Folkesson

> 
> Jonathan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)