linux-kernel - [andersson-remoteproc:ci-next 32/51] drivers/remoteproc/qcom_q6v5_adsp.c:178:56: error: expected ';' before 'if'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202207180116.3mf56M5t-lkp@intel.com>
Date:   Mon, 18 Jul 2022 01:14:37 +0800
From:   kernel test robot <lkp@...el.com>
To:     ran jianping <ran.jianping@....com.cn>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: [andersson-remoteproc:ci-next 32/51]
 drivers/remoteproc/qcom_q6v5_adsp.c:178:56: error: expected ';' before 'if'

tree:   https://github.com/andersson/remoteproc ci-next
head:   7bd43ecf97f8237f4e2a7fdc27a26740b6afa92a
commit: dd0e63e9e8273d34512eed1d936640cba51f9c2a [32/51] remoteproc: qcom: using pm_runtime_resume_and_get to simplify the code
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20220718/202207180116.3mf56M5t-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/andersson/remoteproc/commit/dd0e63e9e8273d34512eed1d936640cba51f9c2a
        git remote add andersson-remoteproc https://github.com/andersson/remoteproc
        git fetch --no-tags andersson-remoteproc ci-next
        git checkout dd0e63e9e8273d34512eed1d936640cba51f9c2a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/remoteproc/qcom_q6v5_adsp.c: In function 'qcom_rproc_pds_enable':
>> drivers/remoteproc/qcom_q6v5_adsp.c:178:56: error: expected ';' before 'if'
     178 |                 ret = pm_runtime_resume_and_get(pds[i])
         |                                                        ^
         |                                                        ;
     179 |                 if (ret < 0) {
         |                 ~~                                      
   drivers/remoteproc/qcom_q6v5_adsp.c:187:1: warning: label 'unroll_pd_votes' defined but not used [-Wunused-label]
     187 | unroll_pd_votes:
         | ^~~~~~~~~~~~~~~


vim +178 drivers/remoteproc/qcom_q6v5_adsp.c

   169	
   170	static int qcom_rproc_pds_enable(struct qcom_adsp *adsp, struct device **pds,
   171					 size_t pd_count)
   172	{
   173		int ret;
   174		int i;
   175	
   176		for (i = 0; i < pd_count; i++) {
   177			dev_pm_genpd_set_performance_state(pds[i], INT_MAX);
 > 178			ret = pm_runtime_resume_and_get(pds[i])
   179			if (ret < 0) {
   180				dev_pm_genpd_set_performance_state(pds[i], 0);
   181				goto unroll_pd_votes;
   182			}
   183		}
   184	
   185		return 0;
   186	
   187	unroll_pd_votes:
   188		for (i--; i >= 0; i--) {
   189			dev_pm_genpd_set_performance_state(pds[i], 0);
   190			pm_runtime_put(pds[i]);
   191		}
   192	
   193		return ret;
   194	}
   195	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp