linux-kernel - Re: [PATCH] kernel: watchdog: fix missing space coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220716173754.62f9cc348cfa08951770bb0b@linux-foundation.org>
Date:   Sat, 16 Jul 2022 17:37:54 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Gavin Keusch <gavinkeusch@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: watchdog: fix missing space coding style issue

On Thu, 14 Jul 2022 10:31:49 +0200 Petr Mladek <pmladek@...e.com> wrote:

> Adding Andrew into Cc who usually takes patches for kernel/watchdog.c.
> 
> Best Regards,
> Petr
> 
> On Wed 2022-07-13 23:04:57, Gavin Keusch wrote:
> > Fixed missing space causing coding style error
> > 
> > Signed-off-by: Gavin Keusch <gavinkeusch@...il.com>
> > ---
> >  kernel/watchdog.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> > index ecb0e8346e65..b6b150c4b179 100644
> > --- a/kernel/watchdog.c
> > +++ b/kernel/watchdog.c
> > @@ -306,7 +306,7 @@ static int is_softlockup(unsigned long touch_ts,
> >  			 unsigned long period_ts,
> >  			 unsigned long now)
> >  {
> > -	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh){
> > +	if ((watchdog_enabled & SOFT_WATCHDOG_ENABLED) && watchdog_thresh) {
> >  		/* Warn about unreasonable delays. */
> >  		if (time_after(now, period_ts + get_softlockup_thresh()))
> >  			return now - touch_ts;

Patch is too minor to justify merging, sorry.  If it fixed 15
coding-style errors then maybe.  But this way just leads to too much
noise.