linux-kernel - Re: [net-next RFC PATCH 4/4] net: dsa: qca8k: split qca8k in common and 8xxx specific code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220718173817.btv2vxcazhioa7pv@skbuf>
Date:   Mon, 18 Jul 2022 20:38:17 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Christian Marangi <ansuelsmth@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [net-next RFC PATCH 4/4] net: dsa: qca8k: split qca8k in common
 and 8xxx specific code

On Mon, Jul 18, 2022 at 07:10:52PM +0200, Christian Marangi wrote:
> On Mon, Jul 18, 2022 at 08:21:35PM +0300, Vladimir Oltean wrote:
> > On Sat, Jul 16, 2022 at 07:49:58PM +0200, Christian Marangi wrote:
> > > The qca8k family reg structure is also used in the internal ipq40xx
> > > switch. Split qca8k common code from specific code for future
> > > implementation of ipq40xx internal switch based on qca8k.
> > > 
> > > While at it also fix minor wrong format for comments and reallign
> > > function as we had to drop static declaration.
> > > 
> > > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > > ---
> > >  drivers/net/dsa/qca/Makefile                  |    1 +
> > >  drivers/net/dsa/qca/{qca8k.c => qca8k-8xxx.c} | 1210 +----------------
> > >  drivers/net/dsa/qca/qca8k-common.c            | 1174 ++++++++++++++++
> > >  drivers/net/dsa/qca/qca8k.h                   |   58 +
> > >  4 files changed, 1245 insertions(+), 1198 deletions(-)
> > >  rename drivers/net/dsa/qca/{qca8k.c => qca8k-8xxx.c} (64%)
> > >  create mode 100644 drivers/net/dsa/qca/qca8k-common.c
> > 
> > Sorry, this patch is very difficult to review for correctness.
> > Could you try to split it to multiple individual function movements?
> 
> You are right.
> Can I split them in category function (bridge function, vlan function,
> ATU...) Or you want them even more split? 

Yes, I think splitting by category is OK as long as the number of
functions being moved at once is trackable by a human being (I'd say at
most 5 functions or so). Use your own judgement while looking at the
output of git format-patch (essentially what a reviewer is looking at).