linux-kernel - Re: [PATCH] drm/i915/gt: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YtWmfuJ9EvnFDh2t@intel.com>
Date:   Mon, 18 Jul 2022 14:29:18 -0400
From:   Rodrigo Vivi <rodrigo.vivi@...el.com>
To:     Jason Wang <wangborong@...rlc.com>
CC:     <daniel@...ll.ch>, <airlied@...ux.ie>,
        <jani.nikula@...ux.intel.com>, <joonas.lahtinen@...ux.intel.com>,
        <tvrtko.ursulin@...ux.intel.com>, <ramalingam.c@...el.com>,
        <thomas.hellstrom@...ux.intel.com>, <matthew.auld@...el.com>,
        <dan.carpenter@...cle.com>, <intel-gfx@...ts.freedesktop.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/i915/gt: Remove unneeded semicolon

On Sun, Jul 17, 2022 at 02:44:39AM +0800, Jason Wang wrote:
> The semicolon after the `}' in line 648 is unneeded.

same here

The line number changes... if you remove the "in line #"
the msg gets better.
With that changed:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@...el.com>

>
> Signed-off-by: Jason Wang <wangborong@...rlc.com>
> ---
>  drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
> index 2c35324b5f68..a69b244f14d0 100644
> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
> @@ -645,7 +645,7 @@ static int scatter_list_length(struct scatterlist *sg)
>  	while (sg && sg_dma_len(sg)) {
>  		len += sg_dma_len(sg);
>  		sg = sg_next(sg);
> -	};
> +	}
>
>  	return len;
>  }
> --
> 2.35.1
>