linux-kernel - Re: [PATCH] sched/fair: optimize entity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 19 Jul 2022 02:53:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Peng Zhang <zhangpeng.00@...edance.com>, mingo@...hat.com,
        peterz@...radead.org, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, bsegall@...gle.com,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org,
        "zhangpeng.00" <zhangpeng.00@...edance.com>
Subject: Re: [PATCH] sched/fair: optimize entity_tick()

Hi Peng,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on linus/master v5.19-rc7 next-20220718]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Peng-Zhang/sched-fair-optimize-entity_tick/20220718-175245
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 401e4963bf45c800e3e9ea0d3a0289d738005fd4
config: nios2-randconfig-s042-20220718 (https://download.01.org/0day-ci/archive/20220719/202207190234.1dmTZy65-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/9dec20bda1c5d0d7a203d393fc1ffa6e296579a9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Peng-Zhang/sched-fair-optimize-entity_tick/20220718-175245
        git checkout 9dec20bda1c5d0d7a203d393fc1ffa6e296579a9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/target/ kernel/sched/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
   kernel/sched/fair.c:927:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct sched_entity *se @@     got struct sched_entity [noderef] __rcu * @@
   kernel/sched/fair.c:927:34: sparse:     expected struct sched_entity *se
   kernel/sched/fair.c:927:34: sparse:     got struct sched_entity [noderef] __rcu *
>> kernel/sched/fair.c:4760:75: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct task_struct *tsk @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/fair.c:4760:75: sparse:     expected struct task_struct *tsk
   kernel/sched/fair.c:4760:75: sparse:     got struct task_struct [noderef] __rcu *curr
   kernel/sched/fair.c:5663:38: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct task_struct *curr @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/fair.c:5663:38: sparse:     expected struct task_struct *curr
   kernel/sched/fair.c:5663:38: sparse:     got struct task_struct [noderef] __rcu *curr
   kernel/sched/fair.c:7232:38: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct task_struct *curr @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/fair.c:7232:38: sparse:     expected struct task_struct *curr
   kernel/sched/fair.c:7232:38: sparse:     got struct task_struct [noderef] __rcu *curr
   kernel/sched/fair.c:7530:38: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct task_struct *curr @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/fair.c:7530:38: sparse:     expected struct task_struct *curr
   kernel/sched/fair.c:7530:38: sparse:     got struct task_struct [noderef] __rcu *curr
   kernel/sched/fair.c:5592:35: sparse: sparse: marked inline, but without a definition
   kernel/sched/fair.c: note: in included file:
   kernel/sched/sched.h:2053:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:2053:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:2053:25: sparse:    struct task_struct *
   kernel/sched/sched.h:2210:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:2210:9: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:2210:9: sparse:    struct task_struct *
   kernel/sched/sched.h:2053:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:2053:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:2053:25: sparse:    struct task_struct *
   kernel/sched/sched.h:2053:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:2053:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:2053:25: sparse:    struct task_struct *

vim +4760 kernel/sched/fair.c

  4759	
> 4760		if (cfs_rq->nr_running > 1 && !test_tsk_need_resched(rq_of(cfs_rq)->curr))
  4761			check_preempt_tick(cfs_rq, curr);
  4762	}
  4763	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp