linux-kernel - Re: [PATCH] selftests/kprobe: Do not test for GRP/ without event failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220718144007.78c5b50f9b123fb80a920054@kernel.org>
Date:   Mon, 18 Jul 2022 14:40:07 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     Masami Hiramatsu (Google) <mhiramat@...nel.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linyu Yuan <quic_linyyuan@...cinc.com>
Subject: Re: [PATCH] selftests/kprobe: Do not test for GRP/ without event
 failures

On Mon, 18 Jul 2022 11:08:53 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> On Tue, 12 Jul 2022 16:17:07 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > From: "Steven Rostedt (Google)" <rostedt@...dmis.org>
> > 
> > A new feature is added where kprobes (and other probes) do not need to
> > explicitly state the event name when creating a probe. The event name will
> > come from what is being attached.
> > 
> > That is:
> > 
> >   # echo 'p:foo/ vfs_read' > kprobe_events
> > 
> > Will no longer error, but instead create an event:
> > 
> >   # cat kprobe_events
> >  p:foo/p_vfs_read_0 vfs_read
> > 
> > This should not be tested as an error case anymore. Remove it from the
> > selftest as now this feature "breaks" the selftest as it no longer fails
> > as expected.
> 
> Good catch!
> 
> Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> 
> BTW, in this case, NO_EVENT_NAME error should not happen anymore.
> Let me cleanup the code.

Oops, no. There is an error case of NO_EVENT_NAME. 'p: vfs_read' will cause
this error because it expects an event name after ':'. Thus, the correct
fix is just removing "foo/":

check_error 'p:^ vfs_read'		# NO_EVENT_NAME

Thank you,

-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>