linux-kernel - Re: [PATCH] media: mc-request.c: Fix comment typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YtXXFZzMnL5IJZoZ@paasikivi.fi.intel.com>
Date:   Mon, 18 Jul 2022 21:56:37 +0000
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Jason Wang <wangborong@...rlc.com>
Cc:     mchehab@...nel.org, laurent.pinchart@...asonboard.com,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: mc-request.c: Fix comment typo

Hi Jason,

On Fri, Jul 15, 2022 at 01:16:46PM +0800, Jason Wang wrote:
> The double `that' is duplicated in line 162, remove one.
> 
> Signed-off-by: Jason Wang <wangborong@...rlc.com>
> ---
>  drivers/media/mc/mc-request.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/mc/mc-request.c b/drivers/media/mc/mc-request.c
> index addb8f2d8939..752ea0bc804b 100644
> --- a/drivers/media/mc/mc-request.c
> +++ b/drivers/media/mc/mc-request.c
> @@ -159,7 +159,7 @@ static long media_request_ioctl_queue(struct media_request *req)
>  	 * state can only happen if either the driver changes the state or if
>  	 * the user cancels the vb2 queue. The driver can only change the state
>  	 * after each object is queued through the req_queue op (and note that
> -	 * that op cannot fail), so setting the state to QUEUED up front is

In this case, the second "that" is there for a reason.

> +	 * op cannot fail), so setting the state to QUEUED up front is
>  	 * safe.
>  	 *
>  	 * The other reason for changing the state is if the vb2 queue is

-- 
Sakari Ailus