linux-kernel - Re: [PATCH v2 2/2] clk: core: Fix runtime PM sequence in clk_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220718222232.lffgerc6qfi6jnha@notapiano>
Date:   Mon, 18 Jul 2022 18:22:32 -0400
From:   Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
To:     Chen-Yu Tsai <wenst@...omium.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v2 2/2] clk: core: Fix runtime PM sequence in
 clk_core_unprepare()

On Wed, Jul 13, 2022 at 04:21:11PM +0800, Chen-Yu Tsai wrote:
> In the original commit 9a34b45397e5 ("clk: Add support for runtime PM"),
> the commit message mentioned that pm_runtime_put_sync() would be done
> at the end of clk_core_unprepare(). This mirrors the operations in
> clk_core_prepare() in the opposite order.
> 
> However, the actual code that was added wasn't in the order the commit
> message described. Move clk_pm_runtime_put() to the end of
> clk_core_unprepare() so that it is in the correct order.
> 
> Fixes: 9a34b45397e5 ("clk: Add support for runtime PM")
> Signed-off-by: Chen-Yu Tsai <wenst@...omium.org>

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>

Thanks,
Nícolas