linux-kernel - Re: [PATCH 19/32] kasan: pass tagged pointers to kasan_save_alloc/free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+fCnZe7b0iNPePpYXswDsjZykphK8vgaYDeeOJCuKbePPDVVw@mail.gmail.com>
Date:   Tue, 19 Jul 2022 00:41:28 +0200
From:   Andrey Konovalov <andreyknvl@...il.com>
To:     Marco Elver <elver@...gle.com>
Cc:     andrey.konovalov@...ux.dev,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Andrey Ryabinin <ryabinin.a.a@...il.com>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Peter Collingbourne <pcc@...gle.com>,
        Evgenii Stepanov <eugenis@...gle.com>,
        Florian Mayer <fmayer@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andrey Konovalov <andreyknvl@...gle.com>
Subject: Re: [PATCH 19/32] kasan: pass tagged pointers to kasan_save_alloc/free_info

On Mon, Jun 20, 2022 at 11:54 AM Marco Elver <elver@...gle.com> wrote:
>
> On Mon, Jun 13, 2022 at 10:14PM +0200, andrey.konovalov@...ux.dev wrote:
> > From: Andrey Konovalov <andreyknvl@...gle.com>
> >
> > Pass tagged pointers to kasan_save_alloc/free_info().
> >
> > This is a preparatory patch to simplify other changes in the series.
> >
> > Signed-off-by: Andrey Konovalov <andreyknvl@...gle.com>
> > ---
> >  mm/kasan/common.c  | 4 ++--
> >  mm/kasan/generic.c | 3 +--
> >  mm/kasan/kasan.h   | 2 +-
> >  mm/kasan/tags.c    | 3 +--
> >  4 files changed, 5 insertions(+), 7 deletions(-)
> >
> > diff --git a/mm/kasan/common.c b/mm/kasan/common.c
> > index f937b6c9e86a..519fd0b3040b 100644
> > --- a/mm/kasan/common.c
> > +++ b/mm/kasan/common.c
> > @@ -227,7 +227,7 @@ static inline bool ____kasan_slab_free(struct kmem_cache *cache, void *object,
> >               return false;
> >
> >       if (kasan_stack_collection_enabled())
> > -             kasan_save_free_info(cache, object, tag);
> > +             kasan_save_free_info(cache, tagged_object);
> >
>
> Variable 'tag' becomes unused in this function after this patch.

Will fix in v2, thanks!