linux-kernel - Re: [PATCH v10 7/8] docs: trace: Add HiSilicon PTT device driver documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Jul 2022 15:10:22 +0800
From:   Yicong Yang <yangyicong@...wei.com>
To:     Bagas Sanjaya <bagasdotme@...il.com>
CC:     <gregkh@...uxfoundation.org>, <alexander.shishkin@...ux.intel.com>,
        <leo.yan@...aro.org>, <james.clark@....com>, <will@...nel.org>,
        <robin.murphy@....com>, <acme@...nel.org>, <peterz@...radead.org>,
        <corbet@....net>, <mathieu.poirier@...aro.org>,
        <mark.rutland@....com>, <jonathan.cameron@...wei.com>,
        <john.garry@...wei.com>, <helgaas@...nel.org>,
        <lorenzo.pieralisi@....com>, <suzuki.poulose@....com>,
        <joro@...tes.org>, <shameerali.kolothum.thodi@...wei.com>,
        <mingo@...hat.com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-pci@...r.kernel.org>, <linux-perf-users@...r.kernel.org>,
        <iommu@...ts.linux-foundation.org>, <iommu@...ts.linux.dev>,
        <linux-doc@...r.kernel.org>, <prime.zeng@...wei.com>,
        <liuqi115@...wei.com>, <zhangshaokun@...ilicon.com>,
        <linuxarm@...wei.com>, Yicong Yang <yangyicong@...ilicon.com>
Subject: Re: [PATCH v10 7/8] docs: trace: Add HiSilicon PTT device driver
 documentation

On 2022/7/15 16:09, Bagas Sanjaya wrote:
> On Thu, Jul 14, 2022 at 05:27:09PM +0800, Yicong Yang wrote:
>> +1. Tx path QoS control
>> +------------------------
>> +
> <snip>
>> +2. Tx path buffer control
>> +-------------------------
>> +
> 
> Shouldn't Tx in the headings above be lowercase (tx)?

Tx is used to keep consistence with other places.

> 
>> +1. filter
>> +---------
> <snip>
>> +2. type
>> +-------
> <snip>
>> +3. direction
>> +------------
> <snip>
>> +4. format
>> +--------------
> <snip>
>> +5. memory management
>> +--------------------
> <snip>
>> +6. decoding
>> +-----------
> 
> I think these headings above should use title case instead.

ok.

> 
> Anyway, the documentation (htmldocs) builds successfully without new
> warnings.
> 
> Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>
> 

Thanks.