linux-kernel - Re: [PATCH] PCI: qcom: Add support for modular builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6db1784-0b21-9bdb-8528-3f814da188b0@mm-sol.com>
Date:   Mon, 18 Jul 2022 10:43:56 +0300
From:   Stanimir Varbanov <svarbanov@...sol.com>
To:     Bjorn Helgaas <helgaas@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc:     Johan Hovold <johan+linaro@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-pci@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: qcom: Add support for modular builds



On 7/15/22 19:56, Bjorn Helgaas wrote:
> On Thu, Jul 14, 2022 at 04:05:41PM +0300, Dmitry Baryshkov wrote:
>> On 14/07/2022 15:19, Stanimir Varbanov wrote:
>>> Please take a look why we made it built-in first [1].
>>>
>>> If arguments there are still valid I don't see why to make it a module
>>> again.
>>>
>>> [1] https://lkml.org/lkml/2016/8/24/694
>>
>> It looks like there is a move to make all non-essential drivers buildable as
>> modules. For example, the Kirin, dra7xx, Meson PCI controllers are now
>> buildable as modules. So I think we can follow that and allow building the
>> pcie-qcom as a module.
> 
> IIUC the arguments in [1] are that:
> 
>   - Kconfig is bool, so it can't be built as a module
>   - there's no sensible use case for unbind
> 
> Those described the situation at the time, and there's no point in
> having .remove() and using module_platform_driver() if Kconfig is
> bool.
> 
> But they don't seem like arguments for why the driver couldn't be
> *made* modular.

I guess the core of the problem was lack of dw_pcie_host_deinit() at
that time.
> 
> I think drivers *should* be modular unless there's a technical reason
> they can't be.

I agree.

> 
> Bjorn

-- 
regards,
Stan