linux-kernel - Re: [PATCH] RDMA: remove useless condition in siw_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YtUjtwduSxH9Z1iQ@unreal>
Date:   Mon, 18 Jul 2022 12:11:19 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Andrey Strachuk <strochuk@...ras.ru>
Cc:     Bernard Metzler <bmt@...ich.ibm.com>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH] RDMA: remove useless condition in siw_create_cq()

On Mon, Jul 11, 2022 at 06:12:51PM +0300, Andrey Strachuk wrote:
> Comparison of 'cq' with NULL is useless since
> 'cq' is a result of container_of and cannot be NULL
> in any reasonable scenario.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Andrey Strachuk <strochuk@...ras.ru>
> Fixes: 303ae1cdfdf7 ("rdma/siw: application interface")
> ---
>  drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied.