linux-kernel - Re: [PATCH v2 0/5] ARM: Convert to ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYmwojupt_024LKA2B0e7zBKmreYYX3ZMC56i5Vrr3fFA@mail.gmail.com>
Date:   Mon, 18 Jul 2022 11:14:37 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Li Huafei <lihuafei1@...wei.com>
Cc:     linux@...linux.org.uk, rmk+kernel@...linux.org.uk, ardb@...nel.org,
        will@...nel.org, broonie@...nel.org, mark.rutland@....com,
        peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
        namhyung@...nel.org, arnd@...db.de, rostedt@...dmis.org,
        nick.hawkins@....com, john@...ozen.org, mhiramat@...nel.org,
        ast@...nel.org, linyujun809@...wei.com, ndesaulniers@...gle.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v2 0/5] ARM: Convert to ARCH_STACKWALK

On Wed, Jul 13, 2022 at 1:02 PM Li Huafei <lihuafei1@...wei.com> wrote:

> This series mainly updates the ARM stack trace code to use the newer and
> simpler arch_stack_walk() interface. Two issues were fixed before that
> (see patch 1 and 2), as well as allowing stack_trace_save_tsk() to
> trace non-current tasks (see patch 3).
>
> v2:
>  - As suggested by Mark, the commit logs for patch 4 and 5 were
>    refined for easy review.

I see I reviewed v1 when v2 was already out but think the
comments still stand.

I think you can already add patches 1 & 2 to Russells patch tracker,
they are straight-forward fixes.

Patches 3-5 may need some elaboration but I trust that you have
done some serious testing since you found the snags in
patches 1 & 2.

Yours,
Linus Walleij