linux-kernel - Re: [PATCH] pinctrl: Don't allow PINCTRL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbcP32Bi51pHOJQM6d-0NgaHxSmxwvEsxmk4PoO1R0Fqg@mail.gmail.com>
Date:   Mon, 18 Jul 2022 12:48:11 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     Basavaraj.Natikar@....com, madcatx@...as.cz,
        jwrdegoede@...oraproject.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: Don't allow PINCTRL_AMD to be a module

On Wed, Jul 13, 2022 at 8:00 PM Mario Limonciello
<mario.limonciello@....com> wrote:

> It was observed that by allowing pinctrl_amd to be loaded
> later in the boot process that interrupts sent to the GPIO
> controller early in the boot are not serviced.  The kernel treats
> these as a spurious IRQ and disables the IRQ.
>
> This problem was exacerbated because it happened on a system with
> an encrypted partition so the kernel object was not accesssible for
> an extended period of time while waiting for a passphrase.
>
> To avoid this situation from occurring, stop allowing pinctrl-amd
> from being built as a module and instead require it to be built-in
> or disabled.
>
> Reported-by: madcatx@...as.cz
> Suggested-by: jwrdegoede@...oraproject.org
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216230
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Patch applied for fixes!
Excellent root causing.

Yours,
Linus Walleij