linux-kernel - Re: [PATCH] perf python: Avoid deprecation warning on distutils

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0b64785-55f2-111c-cec7-a7a90f68f8ac@arm.com>
Date:   Mon, 18 Jul 2022 13:50:22 +0100
From:   James Clark <james.clark@....com>
To:     Ian Rogers <rogers.email@...il.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Ian Rogers <irogers@...gle.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] perf python: Avoid deprecation warning on distutils



On 15/06/2022 02:42, Ian Rogers wrote:
> Fix the following DeprecationWarning:
> 
> tools/perf/util/setup.py:31: DeprecationWarning: The distutils
> package is deprecated and slated for removal in Python 3.12. Use
> setuptools or check PEP 632 for potential alternatives
> 
> Note: the setuptools module may need installing, for example:
> sudo apt install python-setuptools
> 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/util/setup.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/util/setup.py b/tools/perf/util/setup.py
> index c255a2c90cd6..5a3c74bce836 100644
> --- a/tools/perf/util/setup.py
> +++ b/tools/perf/util/setup.py
> @@ -11,7 +11,7 @@ def clang_has_option(option):
>      return [o for o in cc_output if ((b"unknown argument" in o) or (b"is not supported" in o))] == [ ]
>  
>  if cc_is_clang:
> -    from distutils.sysconfig import get_config_vars
> +    from sysconfig import get_config_vars
>      vars = get_config_vars()
>      for var in ('CFLAGS', 'OPT'):
>          vars[var] = sub("-specs=[^ ]+", "", vars[var])
> @@ -28,10 +28,10 @@ if cc_is_clang:
>          if not clang_has_option("-ffat-lto-objects"):
>              vars[var] = sub("-ffat-lto-objects", "", vars[var])
>  
> -from distutils.core import setup, Extension
> +from setuptools import setup, Extension
>  
> -from distutils.command.build_ext   import build_ext   as _build_ext
> -from distutils.command.install_lib import install_lib as _install_lib
> +from setuptools.command.build_ext   import build_ext   as _build_ext
> +from setuptools.command.install_lib import install_lib as _install_lib
>  
>  class build_ext(_build_ext):
>      def finalize_options(self):

Tested it with python 2.7 and 3.8 by running "make install-python_ext PYTHON=..."

Reviewed-by: James Clark <james.clark@....com>