linux-kernel - Re: [PATCH -next] nvmem: node: using put_device to replace kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YtVsuS1J4h5F+KCG@kroah.com>
Date:   Mon, 18 Jul 2022 16:22:49 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Gaosheng Cui <cuigaosheng1@...wei.com>
Cc:     srinivas.kandagatla@...aro.org, rafael@...nel.org,
        linux-kernel@...r.kernel.org, gongruiqi1@...wei.com,
        wangweiyang2@...wei.com
Subject: Re: [PATCH -next] nvmem: node: using put_device to replace
 kfree_const

On Mon, Jul 18, 2022 at 09:06:12PM +0800, Gaosheng Cui wrote:
> We should never be touching the name pointer of a kobject
> directly like this, the device structure itself should be
> cleaning up the memory, not a kfree_const, so using put_device
> to replace kfree_const.
> 
> Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com>
> ---
>  drivers/base/node.c | 2 +-

Please slow down.

Your subject does not match the file name you changed.  Stop and wait a
few days, fix up your patches based on the review, and send a patch
series and then wait for others to review them.

While you wait, take some time and review patches from others, so that
you can get some experience here.

good luck

greg k-h