linux-kernel - Re: [PATCH] tools/power/x86/intel-speed-select: Fix off by one check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d30ed8d43d0db93c5f550bb69931f288285aa2b.camel@linux.intel.com>
Date:   Mon, 18 Jul 2022 08:29:13 -0700
From:   srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] tools/power/x86/intel-speed-select: Fix off by one check

On Mon, 2022-07-18 at 16:17 +0300, Dan Carpenter wrote:
> Change > MAX_DIE_PER_PACKAGE to >= MAX_DIE_PER_PACKAGE to prevent
> accessing one element beyond the end of the array.
> 
> Fixes: 7fd786dfbd2c ("tools/power/x86/intel-speed-select: OOB daemon
> mode")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
Thanks. I will add to PULL request.


> ---
>  tools/power/x86/intel-speed-select/isst-daemon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/power/x86/intel-speed-select/isst-daemon.c
> b/tools/power/x86/intel-speed-select/isst-daemon.c
> index dd372924bc82..d0400c6684ba 100644
> --- a/tools/power/x86/intel-speed-select/isst-daemon.c
> +++ b/tools/power/x86/intel-speed-select/isst-daemon.c
> @@ -41,7 +41,7 @@ void process_level_change(int cpu)
>         time_t tm;
>         int ret;
>  
> -       if (pkg_id >= MAX_PACKAGE_COUNT || die_id >
> MAX_DIE_PER_PACKAGE) {
> +       if (pkg_id >= MAX_PACKAGE_COUNT || die_id >=
> MAX_DIE_PER_PACKAGE) {
>                 debug_printf("Invalid package/die info for cpu:%d\n",
> cpu);
>                 return;
>         }