linux-kernel - Re: [PATCH v2 03/12] reset: add polarfire soc reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7540ac17d28cee09f6f9cce65b696248e545ae1.camel@pengutronix.de>
Date:   Mon, 18 Jul 2022 17:42:08 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Conor.Dooley@...rochip.com
Cc:     paul.walmsley@...ive.com, Daire.McNamara@...rochip.com,
        sboyd@...nel.org, aou@...s.berkeley.edu, robh+dt@...nel.org,
        palmer@...belt.com, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, mturquette@...libre.com,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        krzysztof.kozlowski+dt@...aro.org
Subject: Re: [PATCH v2 03/12] reset: add polarfire soc reset support

Hi Conor,

On Mo, 2022-07-18 at 11:34 +0000, Conor.Dooley@...rochip.com wrote:
[...]
> > +config RESET_POLARFIRE_SOC
> > +	bool "Microchip PolarFire SoC (MPFS) Reset Driver"
> > +	depends on AUXILIARY_BUS && MCHP_CLK_MPFS
> > +	default MCHP_CLK_MPFS
> > +	help
> > +	  This driver supports peripheral reset for the Microchip PolarFire SoC
> > +

Please sort alphabetically by config option.

> >   config RESET_MESON
> >   	tristate "Meson Reset Driver"
> >   	depends on ARCH_MESON || COMPILE_TEST
> > diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
> > index a80a9c4008a7..5fac3a753858 100644
> > --- a/drivers/reset/Makefile
> > +++ b/drivers/reset/Makefile
> > @@ -17,6 +17,7 @@ obj-$(CONFIG_RESET_K210) += reset-k210.o
> >   obj-$(CONFIG_RESET_LANTIQ) += reset-lantiq.o
> >   obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
> >   obj-$(CONFIG_RESET_MCHP_SPARX5) += reset-microchip-sparx5.o
> > +obj-$(CONFIG_RESET_POLARFIRE_SOC) += reset-mpfs.o

Same here. Otherwise,

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

and

Acked-by: Philipp Zabel <p.zabel@...gutronix.de>

to merge this together with the other patches.

regards
Philipp