linux-kernel - Re: sound/soc/intel/boards/sof_ssp_amp.c:97:6: warning: variable 'i' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <443016ec-d597-3f30-874d-c522f457eca0@linux.intel.com>
Date:   Mon, 18 Jul 2022 09:10:27 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     kernel test robot <lkp@...el.com>, Brent Lu <brent.lu@...el.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>
Subject: Re: sound/soc/intel/boards/sof_ssp_amp.c:97:6: warning: variable 'i'
 set but not used



On 7/17/22 19:53, kernel test robot wrote:
> Hi Brent,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   ff6992735ade75aae3e35d16b17da1008d753d28
> commit: 2fe14ff61bd6d4fabe313435dd378b5a38eb6102 ASoC: Intel: sof_ssp_amp: rename driver and support cs35l41 amplifier
> date:   5 months ago
> config: i386-randconfig-a006-20220718 (https://download.01.org/0day-ci/archive/20220718/202207180841.Bkm8xoh8-lkp@intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 45067f8fbf61284839c739807c2da2e2505661eb)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2fe14ff61bd6d4fabe313435dd378b5a38eb6102
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout 2fe14ff61bd6d4fabe313435dd378b5a38eb6102
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash sound/soc/intel/boards/
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All warnings (new ones prefixed by >>):
> 
>>> sound/soc/intel/boards/sof_ssp_amp.c:97:6: warning: variable 'i' set but not used [-Wunused-but-set-variable]
>            int i = 0;
>                ^
>    1 warning generated.

Already fixed by aa4c06e02b41 ("ASoC: Intel: sof_ssp_amp: remove
'set-but-not-used' warning
")


> 
> 
> vim +/i +97 sound/soc/intel/boards/sof_ssp_amp.c
> 
>     89	
>     90	static int sof_card_late_probe(struct snd_soc_card *card)
>     91	{
>     92		struct sof_card_private *ctx = snd_soc_card_get_drvdata(card);
>     93		struct snd_soc_component *component = NULL;
>     94		char jack_name[NAME_SIZE];
>     95		struct sof_hdmi_pcm *pcm;
>     96		int err;
>   > 97		int i = 0;
>     98	
>     99		if (!(sof_ssp_amp_quirk & SOF_HDMI_PLAYBACK_PRESENT))
>    100			return 0;
>    101	
>    102		/* HDMI is not supported by SOF on Baytrail/CherryTrail */
>    103		if (!ctx->idisp_codec)
>    104			return 0;
>    105	
>    106		if (list_empty(&ctx->hdmi_pcm_list))
>    107			return -EINVAL;
>    108	
>    109		if (ctx->common_hdmi_codec_drv) {
>    110			pcm = list_first_entry(&ctx->hdmi_pcm_list, struct sof_hdmi_pcm,
>    111					       head);
>    112			component = pcm->codec_dai->component;
>    113			return hda_dsp_hdmi_build_controls(card, component);
>    114		}
>    115	
>    116		list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) {
>    117			component = pcm->codec_dai->component;
>    118			snprintf(jack_name, sizeof(jack_name),
>    119				 "HDMI/DP, pcm=%d Jack", pcm->device);
>    120			err = snd_soc_card_jack_new(card, jack_name,
>    121						    SND_JACK_AVOUT, &pcm->sof_hdmi,
>    122						    NULL, 0);
>    123	
>    124			if (err)
>    125				return err;
>    126	
>    127			err = hdac_hdmi_jack_init(pcm->codec_dai, pcm->device,
>    128						  &pcm->sof_hdmi);
>    129			if (err < 0)
>    130				return err;
>    131	
>    132			i++;
>    133		}
>    134	
>    135		return hdac_hdmi_jack_port_init(component, &card->dapm);
>    136	}
>    137	
>