linux-kernel - Re: [PATCH] iio: Be consistent with allocation result tests.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Jul 2022 17:44:41 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Joe Simmons-Talbott <joetalbott@...il.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: Be consistent with allocation result tests.

On Sun, 17 Jul 2022 22:03:48 -0400
Joe Simmons-Talbott <joetalbott@...il.com> wrote:

> Make both allocation result tests use the same format
> 
>     if (!ptr)
> 
> Signed-off-by: Joe Simmons-Talbott <joetalbott@...il.com>
If you post two patches to the list that will cause each other to not
apply, please base one on top of the other and say so in the
patch description.

Anyhow, fixed up and applied by hand.

Thanks,

Jonathan

> ---
>  drivers/iio/industrialio-trigger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
> index f504ed351b3e..e22c47f20b4d 100644
> --- a/drivers/iio/industrialio-trigger.c
> +++ b/drivers/iio/industrialio-trigger.c
> @@ -369,7 +369,7 @@ struct iio_poll_func
>  	struct iio_poll_func *pf;
>  
>  	pf = kmalloc(sizeof *pf, GFP_KERNEL);
> -	if (pf == NULL)
> +	if (!pf)
>  		return NULL;
>  	va_start(vargs, fmt);
>  	pf->name = kvasprintf(GFP_KERNEL, fmt, vargs);