linux-kernel - Re: [PATCH v7 0/3] Add Richtek RTQ6056 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Jul 2022 17:52:53 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     cy_huang <u0084500@...il.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        lars@...afoo.de, cy_huang@...htek.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v7 0/3] Add Richtek RTQ6056 support

On Mon, 18 Jul 2022 13:46:00 +0800
cy_huang <u0084500@...il.com> wrote:

> From: ChiYuan Huang <cy_huang@...htek.com>
> 
> This patch series is to enable Richtek RTQ6056 support.
> 
> The RTQ6056 is a high accuracy current-sense monitor with I2C interface, and
> the device provides full information for system by reading out the load current
> and power.

If sending a new version without there being any public replies to the previous version
please reply to that thread yourself to say you are resending and why.
Greatly reduces the chances of me picking up the wrong version!
> 
> Since v7
> - Use 'DEFINE_RUNTIME_DEV_PM_OPS' to replace the explicit declaration of pm_ops.
> 
> Since v6
> - Remove specific rtq6056 ABI document.
> - Update integration time description in general ABI document.
> - Remove the redundant blank line.
> - To prevent the race condition for attribute wrtie and shunt resistor write,
>   use 'iio_device_claim_direct_mode' API.
> - Refine the order for 'action_reset' and 'pm_runtime'.
> - Fix text typo in comment like as ohm to Ohm and timea to time.
> 
> Since v5
> - Fix kernel version text for ABI.
> 
> Since v4
> - Add '__aligned(8)' for timestamp member.
> - Declare timestamp from 'int64_t' to more unified 's64'.
> 
> Since v3
> - change the node name to be generic 'adc' in binding example.
> - Refine pm_runtime API calling order in 'read_channel' API.
> - Fix vshunt wrong scale for divider.
> - Refine the comment text.
> - Use 'devm_add_action_or_reset' to decrease the code usage in probe
>   function.
> - Use RUNTIME_PM_OPS to replace SET_RUNTIME_PM_OPS.
> - minor fix for the comma.
> - Use pm_ptr to replace the direct assigned pm_ops.
> 
> Since v2
> - Change the resistor property name to be generic 'shunt-resistor-micro-ohms'.
> - Rename file from 'rtq6056-adc' to 'rtq6056'.
> - Refine the ABI, if generic already defined it, remove it and check the channel
>   report unit.
> - Add copyright text.
> - include the correct header.
> - change the property parsing name.
> - To use iio_chan_spec address field.
> - Refine each channel separate and shared_by_all.
> - Use pm_runtime and pm_runtime_autosuspend.
> - Remove the shutdown callback. From the HW suggestion, it's not recommended to
>   use battery as the power supply.
> - Check all scale unit (voltage->mV, current->mA, power->milliWatt).
> - Use the read_avail to provide the interface for attribute value list.
> - Add comma for the last element in the const integer array.
> - Refine each ADC label text.
> - In read_label callback, replace snprintf to sysfs_emit.
> 
> ChiYuan Huang (3):
>   dt-bindings: iio: adc: Add rtq6056 adc support
>   iio: adc: Add rtq6056 support
>   Documentation: ABI: testing: rtq6056: Update ABI docs
> 
>  Documentation/ABI/testing/sysfs-bus-iio            |  10 +
>  .../bindings/iio/adc/richtek,rtq6056.yaml          |  56 ++
>  drivers/iio/adc/Kconfig                            |  15 +
>  drivers/iio/adc/Makefile                           |   1 +
>  drivers/iio/adc/rtq6056.c                          | 663 +++++++++++++++++++++
>  5 files changed, 745 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml
>  create mode 100644 drivers/iio/adc/rtq6056.c
>