linux-kernel - Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jul 2022 14:19:12 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and
 generic Gen4 CMT support

Hi Wolfram,

On Tue, Jul 19, 2022 at 9:57 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> On Wed, Jul 13, 2022 at 12:06 PM Wolfram Sang
> <wsa+renesas@...g-engineering.com> wrote:
> > Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> > @@ -83,6 +83,11 @@ properties:
> >                - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
> >            - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
> >
> > +      - items:
> > +          - enum:
> > +              - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
> > +          - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
> > +
> >        - items:
> >            - enum:
> >                - renesas,r8a774a1-cmt1     # 48-bit CMT on RZ/G2M
> > @@ -100,6 +105,11 @@ properties:
> >                - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
> >            - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
> >
> > +      - items:
> > +          - enum:
> > +              - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
> > +          - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
> > +
> >    reg:
> >      maxItems: 1
>
> The above is correct, but you forgot to update the conditional sections
> specifying the number of interrupts.

However, it would have been nice to adhere to the existing sort order
in the file... I will prepare a patch for both issues...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds