linux-kernel - Re: [PATCH v2] random: handle archrandom in plural words

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9qTA90=GEr6h1GZh0CjS+6tpe5uuqkYoJVv79h0zd0w1w@mail.gmail.com>
Date:   Tue, 19 Jul 2022 14:46:31 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Mark Rutland <mark.rutland@....com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        PowerPC <linuxppc-dev@...ts.ozlabs.org>,
        linux-s390@...r.kernel.org, X86 ML <x86@...nel.org>,
        Will Deacon <will@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Borislav Petkov <bp@...e.de>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Johannes Berg <johannes@...solutions.net>,
        Harald Freudenberger <freude@...ux.ibm.com>
Subject: Re: [PATCH v2] random: handle archrandom in plural words

Hi Mark,

On Tue, Jul 19, 2022 at 2:42 PM Mark Rutland <mark.rutland@....com> wrote:
> > -static inline bool __must_check arch_get_random_long(unsigned long *v)
> > +static inline size_t __must_check arch_get_random_words(unsigned long *v, size_t words)
>
> As others have suggested, could we please s/words/longs/? That's a smaller
> change from the existing name, and avoids amibugity were "word" has an
> architecture-specific meaning. e.g. the ARM ARM (ARM DDI 0487G.b) defines:

At first I had thought, "erm, I like 'words'" but decided to wait it
out, and now it's two people with the same probably good objection to
'words', so I'll send a v+1 with 'longs' instead. Thanks for your
feedback. Patch incoming.

> FWIW, other than the naming nits, the arm64 bits look fine to me.

Oh good. Can you send an Acked-by for v+1? Coming up shortly.

Jason