linux-kernel - Re: [PATCH -next] media: vimc: fix wrong pointer passed to PTR_ERR() in vimc_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <165823564899.2228597.7310111477254228194@Monstersaurus>
Date:   Tue, 19 Jul 2022 14:00:48 +0100
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        Hans Verkuil <hverkuil-cisco@...all.nl>
Cc:     mchehab@...nel.org, yunkec@...gle.com, skhan@...uxfoundation.org
Subject: Re: [PATCH -next] media: vimc: fix wrong pointer passed to PTR_ERR() in vimc_create_links()

Hi Yang,

Quoting Yang Yingliang (2022-07-19 08:17:21)
> It should be 'ret_link' passed to PTR_ERR().
> 
> Fixes: d534b9520a12 ("media: vimc: add ancillary lens")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

I believe this patch is correct, and it even has a fixes tag, which is
perhaps one up on the previous one [0] from Hans, though I think he
perhaps sent that before d534b9520a12 was even pushed

But Hans' patch was sent first, so it might be ahead of the race.

[0] https://lore.kernel.org/linux-media/4fd23b1c-8a0a-1691-a4f9-526ec99bd193@xs4all.nl/


But for which ever one gets chosen:

Reviewed-by: Kieran Bingham <kieran.bingham@...asonboard.com>


> ---
>  drivers/media/test-drivers/vimc/vimc-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/test-drivers/vimc/vimc-core.c b/drivers/media/test-drivers/vimc/vimc-core.c
> index c73f91947f44..2ae7a0f11ebf 100644
> --- a/drivers/media/test-drivers/vimc/vimc-core.c
> +++ b/drivers/media/test-drivers/vimc/vimc-core.c
> @@ -211,7 +211,7 @@ static int vimc_create_links(struct vimc_device *vimc)
>                         media_create_ancillary_link(ved_primary->ent, ved_ancillary->ent);
>  
>                 if (IS_ERR(ret_link)) {
> -                       ret = PTR_ERR(link);
> +                       ret = PTR_ERR(ret_link);
>                         goto err_rm_links;
>                 }
>         }
> -- 
> 2.25.1
>